Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Add TP4159 PCIe Infrastructure for Live Migration definitions #891

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

NateThornton
Copy link
Contributor

@NateThornton NateThornton commented Sep 27, 2024

Adds definitions from the newly minted Live Migration specification (TP4159)

TP4159 PCIe Infrastructure for Live Migration 2024.07.30 Ratified.pdf

@NateThornton NateThornton changed the title Add TP1459 PCIe Infrastructure for Live Migration definitions Add TP4159 PCIe Infrastructure for Live Migration definitions Sep 27, 2024
@igaw
Copy link
Collaborator

igaw commented Sep 30, 2024

Please squash all patches into one and use a prefix for subject title, e.g. 'types: ...'

@NateThornton NateThornton changed the title Add TP4159 PCIe Infrastructure for Live Migration definitions types: Add TP4159 PCIe Infrastructure for Live Migration definitions Sep 30, 2024
Adds definitions from the newly minted TP4159 PCIe Infrastructure for
Live Migration specification.

Signed-off-by: Nate Thornton <[email protected]>
@NateThornton
Copy link
Contributor Author

Two checkpatch review errors are due to excess line-length in the error descriptions. I am following precedence here, but if you prefer I can shorten or wrap the strings.

+ [NVME_SC_CONTROLLER_SUSPENDED] = "Controller Suspended: Operation failed because the controller is currently in a suspended state",
Error: WARNING: line length of 150 exceeds 120 columns
+ [NVME_SC_CONTROLLER_NOT_SUSPENDED] = "Controller Not Suspended: Operation failed because the controller is not in a suspended state",
Error: WARNING: line length of 148 exceeds 120 columns

@igaw
Copy link
Collaborator

igaw commented Oct 3, 2024

The changes look okay and we don't have to follow everyhing checkpatch.pl is complaining about. Thanks!

@igaw igaw merged commit d678aa0 into linux-nvme:master Oct 3, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants